Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource azurerm_digital_twins_endpoint_eventgrid #9489

Merged
merged 26 commits into from
Dec 3, 2020

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Nov 26, 2020

Partial fix: #9211

=== RUN TestAccAzureRMDigitalTwinsEndpointEventGrid_basic
=== PAUSE TestAccAzureRMDigitalTwinsEndpointEventGrid_basic
=== CONT TestAccAzureRMDigitalTwinsEndpointEventGrid_basic
--- PASS: TestAccAzureRMDigitalTwinsEndpointEventGrid_basic (245.92s)
=== RUN TestAccAzureRMDigitalTwinsEndpointEventGrid_requiresImport
=== PAUSE TestAccAzureRMDigitalTwinsEndpointEventGrid_requiresImport
=== CONT TestAccAzureRMDigitalTwinsEndpointEventGrid_requiresImport
--- PASS: TestAccAzureRMDigitalTwinsEndpointEventGrid_requiresImport (235.73s)
=== RUN TestAccAzureRMDigitalTwinsEndpointEventGrid_updateEventGrid
=== PAUSE TestAccAzureRMDigitalTwinsEndpointEventGrid_updateEventGrid
=== CONT TestAccAzureRMDigitalTwinsEndpointEventGrid_updateEventGrid
--- PASS: TestAccAzureRMDigitalTwinsEndpointEventGrid_updateEventGrid (285.27s)
=== RUN TestAccAzureRMDigitalTwinsEndpointEventGrid_updateDeadLetter
=== PAUSE TestAccAzureRMDigitalTwinsEndpointEventGrid_updateDeadLetter
=== CONT TestAccAzureRMDigitalTwinsEndpointEventGrid_updateDeadLetter
--- PASS: TestAccAzureRMDigitalTwinsEndpointEventGrid_updateDeadLetter (301.37s)

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yupwei68 This is looking really good, left a few comments. I think this is really close, thanks for the PR! 🚀


resource "azurerm_digital_twins_endpoint_eventgrid" "example" {
name = "example-EG"
digital_twins_instance_id = azurerm_digital_twins_instance.example.id
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
digital_twins_instance_id = azurerm_digital_twins_instance.example.id
instance_id = azurerm_digital_twins_instance.example.id

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

digital_twins_id?


* `name` - (Required) The name which should be used for this Digital Twins Eventgrid Endpoint. Changing this forces a new Digital Twins Eventgrid Endpoint to be created.

* `digital_twins_instance_id` - (Required) The resource ID of the Digital Twins Instance. Changing this forces a new Digital Twins Eventgrid Endpoint to be created.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `digital_twins_instance_id` - (Required) The resource ID of the Digital Twins Instance. Changing this forces a new Digital Twins Eventgrid Endpoint to be created.
* `instance_id` - (Required) The resource ID of the Digital Twins Instance. Changing this forces a new Digital Twins Eventgrid Endpoint to be created.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

digital_twins_id?

@yupwei68
Copy link
Contributor Author

yupwei68 commented Dec 1, 2020

Thanks for your comments, @WodansSon . Corresponding changes have been pushed, except some my minor concerns. The parser and the parser test are all generated from Tom's tool, by https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/internal/services/digitaltwins/resourceids.go. I wonder if our changes will be overwrote if we make changes.

WodansSon
WodansSon previously approved these changes Dec 1, 2020
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yupwei68 Thanks for pushing these changes. Since some of the changes are auto-generated the LGTM now! Thanks! 🚀

@WodansSon WodansSon added this to the v2.39.0 milestone Dec 2, 2020
@WodansSon WodansSon dismissed their stale review December 2, 2020 19:52

Need to resolve conflicts

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! 🚀

@WodansSon
Copy link
Collaborator

image

@WodansSon WodansSon merged commit dc4ed94 into hashicorp:master Dec 3, 2020
WodansSon added a commit that referenced this pull request Dec 3, 2020
@ghost
Copy link

ghost commented Dec 4, 2020

This has been released in version 2.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.39.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
@yupwei68 yupwei68 deleted the wyp-digitaltwins-endpoint branch June 7, 2021 06:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Digital Twins
3 participants