Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kusto_cluster - Add support for engine #9696

Merged
merged 5 commits into from
Dec 6, 2020

Conversation

kosinsky
Copy link
Contributor

@kosinsky kosinsky commented Dec 4, 2020

Kusto aka ADX added support for EngineV3 which promises better performance. Adding engine argument to the kusto_cluster resources.

Updating kusto API to 2020-09-18 to use new EngineType field in ClusterProperties type

Implements #9695

Test run:

make testacc TEST='./azurerm/internal/services/kusto/tests/' TESTARGS='-run=TestAccAzureRMKustoCluster_ -parallel=3' TESTTIMEOUT='300m' 
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/kusto/tests/ -v -run=TestAccAzureRMKustoCluster_ -parallel=3 -timeout 300m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMKustoCluster_basic
=== PAUSE TestAccAzureRMKustoCluster_basic
=== RUN   TestAccAzureRMKustoCluster_update
=== PAUSE TestAccAzureRMKustoCluster_update
=== RUN   TestAccAzureRMKustoCluster_withTags
=== PAUSE TestAccAzureRMKustoCluster_withTags
=== RUN   TestAccAzureRMKustoCluster_sku
=== PAUSE TestAccAzureRMKustoCluster_sku
=== RUN   TestAccAzureRMKustoCluster_zones
=== PAUSE TestAccAzureRMKustoCluster_zones
=== RUN   TestAccAzureRMKustoCluster_identitySystemAssigned
=== PAUSE TestAccAzureRMKustoCluster_identitySystemAssigned
=== RUN   TestAccAzureRMKustoCluster_vnet
=== PAUSE TestAccAzureRMKustoCluster_vnet
=== RUN   TestAccAzureRMKustoCluster_languageExtensions
=== PAUSE TestAccAzureRMKustoCluster_languageExtensions
=== RUN   TestAccAzureRMKustoCluster_optimizedAutoScale
=== PAUSE TestAccAzureRMKustoCluster_optimizedAutoScale
=== RUN   TestAccAzureRMKustoCluster_engineV3
=== PAUSE TestAccAzureRMKustoCluster_engineV3
=== CONT  TestAccAzureRMKustoCluster_basic
=== CONT  TestAccAzureRMKustoCluster_vnet
=== CONT  TestAccAzureRMKustoCluster_sku
--- PASS: TestAccAzureRMKustoCluster_vnet (1381.34s)
=== CONT  TestAccAzureRMKustoCluster_engineV3
--- PASS: TestAccAzureRMKustoCluster_basic (1409.33s)
=== CONT  TestAccAzureRMKustoCluster_withTags
--- PASS: TestAccAzureRMKustoCluster_sku (1914.09s)
=== CONT  TestAccAzureRMKustoCluster_identitySystemAssigned
--- PASS: TestAccAzureRMKustoCluster_withTags (1365.42s)
=== CONT  TestAccAzureRMKustoCluster_zones
--- PASS: TestAccAzureRMKustoCluster_engineV3 (1682.15s)
=== CONT  TestAccAzureRMKustoCluster_optimizedAutoScale
--- PASS: TestAccAzureRMKustoCluster_identitySystemAssigned (1470.83s)
=== CONT  TestAccAzureRMKustoCluster_languageExtensions
    TestAccAzureRMKustoCluster_zones: testing.go:684: Step 0 error: Check failed: Check 3/3 error: azurerm_kusto_cluster.test: Attribute 'zones.0' expected "1", got "2"
--- FAIL: TestAccAzureRMKustoCluster_zones (1582.72s)
=== CONT  TestAccAzureRMKustoCluster_update
--- PASS: TestAccAzureRMKustoCluster_optimizedAutoScale (2296.77s)
--- PASS: TestAccAzureRMKustoCluster_languageExtensions (2731.64s)
--- PASS: TestAccAzureRMKustoCluster_update (2664.86s)

TestAccAzureRMKustoCluster_zones fails in master too
Also, I fixed TestAccAzureRMKustoCluster_optimizedAutoScale, let me know if I need to do that fix in separate PR

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v2.40.0 milestone Dec 6, 2020
@mbfrahry mbfrahry changed the title Adds support for EngineV3 in kusto_cluster azurerm_kusto_cluster - Add support for engine Dec 6, 2020
@mbfrahry mbfrahry merged commit 96d2e02 into hashicorp:master Dec 6, 2020
mbfrahry added a commit that referenced this pull request Dec 6, 2020
@ghost
Copy link

ghost commented Dec 10, 2020

This has been released in version 2.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants