Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_service_managed_certificate - create certificate in service plan resource group #9701

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Conversation

AdamCoulterOz
Copy link
Contributor

@AdamCoulterOz AdamCoulterOz commented Dec 6, 2020

Fixes #9699

FYI - @jackofallops

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch @AdamCoulterOz - one minor change requested, but otherwise will be good to merge.

@AdamCoulterOz
Copy link
Contributor Author

AdamCoulterOz commented Dec 9, 2020

@jackofallops just a reminder this small fix is still waiting... we need this to make 2.40 also in order to make use of all the other work. I already addressed your previous feedback.

@ghost ghost removed the waiting-response label Dec 9, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AdamCoulterOz - LGTM now 👍

@jackofallops
Copy link
Member

Tests passing:

=== RUN   TestAccAzureRMAppServiceManagedCertificate_basicLinux
=== PAUSE TestAccAzureRMAppServiceManagedCertificate_basicLinux
=== CONT  TestAccAzureRMAppServiceManagedCertificate_basicLinux
--- PASS: TestAccAzureRMAppServiceManagedCertificate_basicLinux (225.23s)
=== RUN   TestAccAzureRMAppServiceManagedCertificate_requiresImport
=== PAUSE TestAccAzureRMAppServiceManagedCertificate_requiresImport
=== CONT  TestAccAzureRMAppServiceManagedCertificate_requiresImport
--- PASS: TestAccAzureRMAppServiceManagedCertificate_requiresImport (229.70s)
=== RUN   TestAccAzureRMAppServiceManagedCertificate_basicWindows
=== PAUSE TestAccAzureRMAppServiceManagedCertificate_basicWindows
=== CONT  TestAccAzureRMAppServiceManagedCertificate_basicWindows
--- PASS: TestAccAzureRMAppServiceManagedCertificate_basicWindows (220.59s)
PASS

@jackofallops jackofallops changed the title create cert in service plan rg azurerm_app_service_managed_certificate - create certificate in service plan resource group Dec 10, 2020
@jackofallops jackofallops merged commit cf86a65 into hashicorp:master Dec 10, 2020
jackofallops added a commit that referenced this pull request Dec 10, 2020
@ghost
Copy link

ghost commented Dec 10, 2020

This has been released in version 2.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.40.0"
}
# ... other configuration ...

@AdamCoulterOz AdamCoulterOz deleted the certFixResGroup branch December 11, 2020 11:46
@ghost
Copy link

ghost commented Jan 9, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants