provider: deprecate skip_credentials_validation

[magodo]

This field got added to allow people to input fake data to get terraform validate working - which is fine but some people then complained that plan showed invalid data because of it - in short it shouldn’t have been added in the first.

[tombuildsstuff]

hey @magodo

Thanks for this PR - taking a look through this mostly LGTM - but we'll need to add a deprecation message to the existing field rather than outright removing it for the moment (although the behaviour can be removed, since this hasn't worked since ~2.0 anyway).

Thanks!

[tombuildsstuff]

LGTM 👍

[ghost]

This has been released in version 2.47.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.47.0"
}
# ... other configuration ...

[NewGyu]

Hi @magodo . Should this warning be shown evenif the field is not specified explicitly?

My main.tf is as below. The skip_credentials_validation is not specified explicitly.

provider "azurerm" {
  subscription_id = "6fd834f7-50a1-4d6a-b4f5-735ed47cbe9f"
  features {}
}

But the message below is shown when terraform plan is running.

Warning: "skip_credentials_validation": [DEPRECATED] This field is deprecated and will be removed in version 3.0 of the Azure Provider.

Is this expected?

[NewGyu]

Sorry, #10560 means that. (I didn't read this thread enough.)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!