Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: generating the Resource ID Formatter/Parsing functions #9558

Merged
merged 17 commits into from Nov 30, 2020
Merged

sql: generating the Resource ID Formatter/Parsing functions #9558

merged 17 commits into from Nov 30, 2020

Conversation

tombuildsstuff
Copy link
Member

No description provided.

@tombuildsstuff tombuildsstuff added service/mssql Microsoft SQL Server refactor labels Nov 30, 2020
@tombuildsstuff tombuildsstuff added this to the v2.39.0 milestone Nov 30, 2020
@tombuildsstuff tombuildsstuff requested a review from a team November 30, 2020 10:12
@ghost ghost added the size/XXL label Nov 30, 2020
@tombuildsstuff
sql: updating to use the generated resource id names
095d55b
@tombuildsstuff
sql: generating the Resource ID Formatter/Parser for Database
440ef63
@tombuildsstuff
sql: generating the Resource ID for SQL
035149e
@tombuildsstuff
r/sql_server: refactoring to use the ID Formatter/Parser
4cfffee
@tombuildsstuff
sql: generating a Resource ID Formatter/Parser for FirewallRules
5bc9a34
@tombuildsstuff
r/sql_firewall_rule: switching to use the formatter/parser func
ef0c5ec
@tombuildsstuff
sql: generating the VirtualNetworkRule Resource ID formatter/parser
ec31694
@tombuildsstuff
sql: switching to use the ID Parser for VirtualNetworkRule
f583a86
@tombuildsstuff
sql: generating the ID Formatter/Parser for Failover Group
a1bedd9
@tombuildsstuff
r/sql_failover_group: switching to use the ID Parser
7c3a360
@tombuildsstuff
sql: generating an ID Parser for ElasticPool
9d5fd98
@tombuildsstuff
r/sql_elasticpool: switching to use the ID Parser
038d2bf
@tombuildsstuff
r/sql_elasticpool: refactoring to remove the crashes
13fc048
@tombuildsstuff
sql: generating the Resource ID Formatter/Parser for AD Administrator
9258740
@tombuildsstuff
r/sql_administrator: switching to use the generated Parse function
8d582b4
@tombuildsstuff
validate: removing the unused DatabaseID function
fcdf962
@tombuildsstuff
sql: regenerating using the latest generator
d0aee9c
jackofallops
jackofallops approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer manicminer merged commit e6b3460 into master Nov 30, 2020
@manicminer manicminer deleted the r/resource-ids/sql branch November 30, 2020 14:32
@ghost
Copy link

ghost commented Dec 4, 2020

This has been released in version 2.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.39.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Dec 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
refactor service/mssql Microsoft SQL Server size/XXL
Projects
None yet
Milestone
v2.39.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tombuildsstuff @jackofallops @manicminer