Add Load Balancer Rule protocol support #22
Conversation
There was a problem hiding this comment.
Thanks for this PR @stuwil! Unfortunately I can't verify that tcp-proxy is a valid input value. It's not in the docs... Can you point me to something that verifies this?
| @@ -170,6 +182,11 @@ func resourceCloudStackLoadBalancerRuleRead(d *schema.ResourceData, meta interfa | |||
| d.Set("network_id", lb.Networkid) | |||
| } | |||
|
|
|||
| // Only set protocol if user specified it to avoid spurious diffs | |||
There was a problem hiding this comment.
This is not needed if you set Computed: true for the protocol field.
|
Thanks for the review! Yes, unfortunately, the CloudStack API docs are pretty vague on it's usage. Here's the code reference for the "Internal Load Balancer" (haproxy) protocol offerings: The load balancer protocol offerings do differ when using external load balancers (see this search for an example). It might make more sense in this case to be a bit less explicit in the docs... it's unfortunate there's no apparent good reference for the possible values though, given the LB variations. Let me know what you think and I can update accordingly. |
|
Cool! In that case it's all good 👍 Thanks... |
This adds support for the Load Balancer Rule
protocolfield, added in CloudStack 4.3. The primary use of this optional field is to specify a protocol oftcp-proxy, which enablesPROXYprotocol headers to be sent to the load balanced instance(s).