data-source/external: Use ReadWithoutTimeout instead of ReadContext #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: #164 Proposed CHANGELOG entry: ``` data-source/external: Prevented unexpected error after 20 minutes of program execution ``` The additional acceptance test is placed behind an environment variable flag since it is extremely long running compared to other testing. Without the flag: ```console $ TF_ACC=1 go test -count=1 -run='TestDataSource_20MinuteTimeout' -v ./internal/provider === RUN TestDataSource_20MinuteTimeout data_source_test.go:197: Skipping this test since the TF_ACC_EXTERNAL_TIMEOUT_TEST environment variable is not set to any value. This test requires 20 minutes to run, so it is disabled by default. --- SKIP: TestDataSource_20MinuteTimeout (0.00s) PASS ok github.com/terraform-providers/terraform-provider-external/internal/provider 0.982s ``` With the flag: ```console $ TF_ACC=1 TF_ACC_EXTERNAL_TIMEOUT_TEST=1 go test -count=1 -run='TestDataSource_20MinuteTimeout' -timeout=30m -v ./internal/provider === RUN TestDataSource_20MinuteTimeout --- PASS: TestDataSource_20MinuteTimeout (1205.18s) PASS ok github.com/terraform-providers/terraform-provider-external/internal/provider 1205.465s ```
1 task
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #164
Proposed CHANGELOG entry:
The additional acceptance test is placed behind an environment variable flag since it is extremely long running compared to other testing.
Without the flag:
With the flag: