Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-source/external: Switch to tflog, add trace log for program being executed #95

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

bflad
Copy link
Member

@bflad bflad commented Dec 20, 2021

Closes #22

Provider will now produce trace logging such as:

2021-12-20T09:45:21.305-0500 [TRACE] sdk.proto: Received request: tf_data_source_type=external tf_proto_version=5 tf_provider_addr=registry.terraform.io/hashicorp/external tf_req_id=f7754152-04ab-826b-3dec-c68af595576a tf_rpc=ReadDataSource
2021-12-20T09:45:21.305-0500 [TRACE] sdk.proto: Calling downstream: tf_data_source_type=external tf_proto_version=5 tf_provider_addr=registry.terraform.io/hashicorp/external tf_req_id=f7754152-04ab-826b-3dec-c68af595576a tf_rpc=ReadDataSource
2021-12-20T09:45:21.305-0500 [TRACE] external: Executing external program: tf_data_source_type=external tf_provider_addr=registry.terraform.io/hashicorp/external tf_req_id=f7754152-04ab-826b-3dec-c68af595576a tf_rpc=ReadDataSource program=/Users/bflad/go/bin/tf-acc-external-data-source
2021-12-20T09:45:21.375-0500 [TRACE] external: Executed external program: tf_data_source_type=external tf_provider_addr=registry.terraform.io/hashicorp/external tf_req_id=f7754152-04ab-826b-3dec-c68af595576a tf_rpc=ReadDataSource program=/Users/bflad/go/bin/tf-acc-external-data-source output=""
2021-12-20T09:45:21.375-0500 [TRACE] sdk.proto: Called downstream: tf_data_source_type=external tf_proto_version=5 tf_provider_addr=registry.terraform.io/hashicorp/external tf_req_id=f7754152-04ab-826b-3dec-c68af595576a tf_rpc=ReadDataSource
2021-12-20T09:45:21.375-0500 [TRACE] sdk.proto: Served request: tf_data_source_type=external tf_proto_version=5 tf_provider_addr=registry.terraform.io/hashicorp/external tf_req_id=f7754152-04ab-826b-3dec-c68af595576a tf_rpc=ReadDataSource

…g executed

Reference: #22

Provider will now produce trace logging such as:

```
2021-12-20T09:45:21.305-0500 [TRACE] sdk.proto: Received request: tf_data_source_type=external tf_proto_version=5 tf_provider_addr=registry.terraform.io/hashicorp/external tf_req_id=f7754152-04ab-826b-3dec-c68af595576a tf_rpc=ReadDataSource
2021-12-20T09:45:21.305-0500 [TRACE] sdk.proto: Calling downstream: tf_data_source_type=external tf_proto_version=5 tf_provider_addr=registry.terraform.io/hashicorp/external tf_req_id=f7754152-04ab-826b-3dec-c68af595576a tf_rpc=ReadDataSource
2021-12-20T09:45:21.305-0500 [TRACE] external: Executing external program: tf_data_source_type=external tf_provider_addr=registry.terraform.io/hashicorp/external tf_req_id=f7754152-04ab-826b-3dec-c68af595576a tf_rpc=ReadDataSource program=/Users/bflad/go/bin/tf-acc-external-data-source
2021-12-20T09:45:21.375-0500 [TRACE] external: Executed external program: tf_data_source_type=external tf_provider_addr=registry.terraform.io/hashicorp/external tf_req_id=f7754152-04ab-826b-3dec-c68af595576a tf_rpc=ReadDataSource program=/Users/bflad/go/bin/tf-acc-external-data-source output=""
2021-12-20T09:45:21.375-0500 [TRACE] sdk.proto: Called downstream: tf_data_source_type=external tf_proto_version=5 tf_provider_addr=registry.terraform.io/hashicorp/external tf_req_id=f7754152-04ab-826b-3dec-c68af595576a tf_rpc=ReadDataSource
2021-12-20T09:45:21.375-0500 [TRACE] sdk.proto: Served request: tf_data_source_type=external tf_proto_version=5 tf_provider_addr=registry.terraform.io/hashicorp/external tf_req_id=f7754152-04ab-826b-3dec-c68af595576a tf_rpc=ReadDataSource
```
@bflad bflad added this to the v2.2.0 milestone Dec 20, 2021
@bflad bflad requested a review from a team December 20, 2021 14:51
@bflad bflad merged commit 9caa65f into main Dec 20, 2021
@bflad bflad deleted the bflad-ds-tflog branch December 20, 2021 18:15
bflad added a commit that referenced this pull request Dec 20, 2021
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

external provider does not log what its trying to do
2 participants