Auto-generate the Cloud IoT Core Device resource #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ignore python virtualenv * Automatically generate IoT Core Devices * Basic Cloud IoT device test * Fix tests * Full test * Fix import * Use vars for names * Fix tests * Fix update test * Fix review comments * Update templates/terraform/examples/cloudiot_device_basic.tf.erb Co-authored-by: Sam Levenick <slevenick@google.com> * Update templates/terraform/examples/cloudiot_device_basic.tf.erb Co-authored-by: Sam Levenick <slevenick@google.com> * Update templates/terraform/examples/cloudiot_device_full.tf.erb Co-authored-by: Sam Levenick <slevenick@google.com> * Update templates/terraform/examples/cloudiot_device_full.tf.erb Co-authored-by: Sam Levenick <slevenick@google.com> * Fix review comments * Remove allow_empty_object from expirationTime * Set credentials.expirationTime to accept default values * Extend comment Co-authored-by: Sam Levenick <slevenick@google.com> Signed-off-by: Modular Magician <magic-modules@google.com>
ghost
added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR automatically generates the Cloud IoT Core Device terraform resource, and the relevant acceptance tests.
Closes hashicorp/terraform-provider-google#1495.
Derived from GoogleCloudPlatform/magic-modules#3637