Add generated resources for http(s)_health_check, updates to backend_bucket, and import helpers #1177
Conversation
| if err != nil { | ||
| return handleNotFoundError(err, d, fmt.Sprintf("HTTP Health Check %q", d.Get("name").(string))) | ||
| return err |
There was a problem hiding this comment.
We should update our magic module to handle 404 in delete properly
There was a problem hiding this comment.
We don't usually do 404 checking in deletes, since hypothetically the refresh would have caught it and removed the resource from state. Do you have an example resource that does?
There was a problem hiding this comment.
this resource, look at the diff
There was a problem hiding this comment.
It's diffing it against read() because the order of the functions changed
|
Pushed a quick commit with some fixes that came up in the test run. All |
…bucket, and import helpers (hashicorp#1177) * add import helpers for generated code * Updates to backend bucket and transport.go from MM * add generated http(s)_health_check resources * name is required; transport import style * update docs with new fields/timeouts * fixes
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
(I separated the changes out into logical commits, but let me know if you want me to separate out the PRs too)