Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix instance template interaction with regional disks, make docs more clear about valid values #2138

Merged
merged 1 commit into from
Oct 1, 2018

Conversation

danawillow
Copy link
Contributor

fixes #2128

@ghost ghost added the size/m label Oct 1, 2018
Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM. I'm just curious why we can't use a self_link here and can only use a name. It is because we can't map 1:1 between an image family and self link?

@danawillow
Copy link
Contributor Author

It's an API thing: https://cloud.google.com/compute/docs/reference/rest/v1/instanceTemplates

Note that for InstanceTemplate, specify the disk name, not the URL for the disk.

(it does seem to accept one for regional disks, but it's not documented so I'm not going to document it on our side)

@danawillow danawillow merged commit 250cfa3 into hashicorp:master Oct 1, 2018
@danawillow danawillow deleted the is-2128 branch October 1, 2018 18:07
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
@ghost
Copy link

ghost commented Nov 16, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forces new ressource everytime because of v1 vs beta link
2 participants