Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to edit existing BigQuery dataset ACL access #3990

Closed
kardiff18 opened this issue Jul 8, 2019 · 4 comments
Closed

Ability to edit existing BigQuery dataset ACL access #3990

kardiff18 opened this issue Jul 8, 2019 · 4 comments

Comments

@kardiff18
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Currently for the BigQuery dataset resource, you cannot append roles to the ACL. It would be nice to import the dataset reference, and then be able to add a new role to it. Right now it will revoke any existing permissions, so you cannot edit access to existing datasets without re-entering all OWNER permisisons and losing existing permissions.

This could be similar to the iam_member_role resource which lets you add in new roles rather than revoking all existing IAM roles.

New or Affected Resource(s)

  • google_bigquery_dataset
@griffinator76
Copy link

Maybe something similar to bucket access control resource that exists for storage buckets? https://www.terraform.io/docs/providers/google/r/storage_bucket_access_control.html

@rileykarson
Copy link
Collaborator

It's very likely that this and #2686 and are resolved by adding a google_bigquery_dataset_access_member resource, similar to that or to *_iam_member resources.

@danawillow
Copy link
Contributor

Closing this as a dupe since #2686 is older and they're functionally asking for the same thing.

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants