Add support for Cloud SQL CA Cert (#635) #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose the 'ServerCaCert' object from the Cloud SQL Instance[1] Related: hashicorp#635 - Solves first point [1] https://cloud.google.com/sql/docs/mysql/admin-api/v1beta4/instances#resource
danawillow
reviewed
Jan 30, 2018
| "server_ca_cert": &schema.Schema{ | ||
| Type: schema.TypeList, | ||
| Computed: true, | ||
| Optional: true, |
There was a problem hiding this comment.
(hello friends I know this is already merged but-)
since this is only set on read (and not something passed in to create or update), it should be only computed and not also optional.
There was a problem hiding this comment.
thanks! follow up inbound
johnsonj
added a commit
to johnsonj/terraform-provider-google
that referenced
this pull request
Jan 30, 2018
Response to PR comment: hashicorp#1020 (review)
danawillow
pushed a commit
that referenced
this pull request
Jan 30, 2018
Response to PR comment: #1020 (review)
rosbo
pushed a commit
that referenced
this pull request
May 30, 2018
* Add "server_ca_cert" Attribute reference Documents the addition of the `server_ca_cert` attribute for use in configuring SSL with GCP SQL Instances - added in PR #1020 * Updated formatting Updates formatting to match the above fields.
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
* Add "server_ca_cert" Attribute reference Documents the addition of the `server_ca_cert` attribute for use in configuring SSL with GCP SQL Instances - added in PR hashicorp#1020 * Updated formatting Updates formatting to match the above fields.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the 'ServerCaCert' object from the Cloud SQL Instance[1]
Related: #635 - Solves first point
[1] https://cloud.google.com/sql/docs/mysql/admin-api/v1beta4/instances#resource