Switch to using Go modules. #2666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a link to storage_bucket_acl ressource documentation page. It's easier than scrolling and scrolling or copy text and search it on the page. Thank you !
fix a typo
Hi! Now any changes of cloud build trigger create new one, this PR makes triggers modifiable in place. I referred to [bigquery dataset](https://github.com/terraform-providers/terraform-provider-google/blob/9f0b792f091ce1a27f718d23184a481d6b20ec05/google/resource_bigquery_dataset.go#L353). If theare are better examples, I'd like to know them.
Update regional cluster example to point cluster to google_container_cluster.regional.name rather than google_container_cluster.primary.name
This reverts commit 065128e.
This reverts commit 02eb26b.
<!-- This change is generated by MagicModules. --> /cc @rileykarson
<!-- This change is generated by MagicModules. --> /cc @danawillow
<!-- This change is generated by MagicModules. --> /cc @rileykarson
<!-- This change is generated by MagicModules. --> /cc @danawillow
<!-- This change is generated by MagicModules. --> /cc @danawillow
<!-- This change is generated by MagicModules. --> /cc @danawillow
blocking GoogleCloudPlatform/magic-modules#630 This resource won't be tested between this merging and the MM pr merging
<!-- This change is generated by MagicModules. --> /cc @rileykarson
<!-- This change is generated by MagicModules. --> /cc @danawillow
``` govendor fetch google.golang.org/api/serviceusage/v1@04bb50b6b83d0e72253821af8cf3252d8e866517 ``` #2646 will need to be done after migrating the existing resources off `v1beta1`
<!-- This change is generated by MagicModules. --> /cc @danawillow
<!-- This change is generated by MagicModules. --> /cc @danawillow
<!-- This change is generated by MagicModules. --> /cc @danawillow
This migrates our vendor.json to use Go 1.11's modules system, and replaces the vendor folder with the output of go mod vendor. The vendored code should remain basically the same; I believe some tree shaking of packages and support scripts/licenses/READMEs/etc. happened.
paddycarver
force-pushed
the
paddy_go_mod
branch
from
c2c0fa7
to
f8a571c
Compare
paddycarver
added a commit
that referenced
this pull request
Dec 18, 2018
This migrates our vendor.json to use Go 1.11's modules system, and replaces the vendor folder with the output of go mod vendor. The vendored code should remain basically the same; I believe some tree shaking of packages and support scripts/licenses/READMEs/etc. happened. This also fixes Travis and our Makefile to no longer use govendor. (This is a replacement for #2666, except based on @ndmckinley's work to get 2.0.0 stuff on master.)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates our vendor.json to use Go 1.11's modules system, and replaces the vendor folder with the output of
go mod vendor.The vendored code should remain basically the same; I believe some tree shaking of packages and support scripts/licenses/READMEs/etc. happened.