Update gometalinter for modules, add staticcheck

[rileykarson]

This isn't working locally, but it matches the changes made in hashicorp/terraform-provider-azurerm#2722 so maybe something freaky is going on and it will only work in CI?

Edit: This only works in CI (well, at least doesn't work locally for me) but the same is true in the Azure provider. Most of those rules can be turned back on provided we make the corresponding code changes, but let's bring back unused for now. I'll dupe over to tpgb on approval.

[dominikh]

Typo, -"SA6000" should be "-SA6000"

[rileykarson]

Thanks!

[rileykarson]

@paddycarver: Re-requesting because this changed a bunch based on reading the AWS / Azure providers' configs as well.

I took the output from hashicorp/terraform-provider-azurerm#2787 and added it in our Makefile, alongside some other small changes.

I found that modules didn't work well with gometalinter, so I explicitly disabled them on every command. I have GO111MODULE=on set locally, and it caused me some... weird dependency issues.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!