Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This property is not correctly handled on the API - we can work around it here. #4588

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Sep 30, 2019

Original Author: @ndmckinley

compute: Added ability to set `quic_override` on `google_compute_https_target_proxy` to empty.

…d it here.

Signed-off-by: Modular Magician <magic-modules@google.com>
@knapo
Copy link

knapo commented Oct 14, 2019

hey @ndmckinley!

After upgrading to 2.17.0, Terraform wants to set quic_override on existing resources and I started getting:

Error updating TargetHttpsProxy "....": googleapi: Error 403: Required 'compute.targetHttpsProxies.setQuicOverride' permission for ...

However I can't see compute.targetHttpsProxies.setQuicOverride role on GCP and my service account has all compute.targetHttpsProxies assigned.

Have you experienced such issue? thanks for the help

@nat-henderson
Copy link
Contributor

I'm not terribly surprised that it wants to set it on existing resources, depending on what the state of those resources was. Mind posting your diff so I can make sure it's expected?

I'm not sure what to think about the permissions issue, I'll dig into that.

@nat-henderson
Copy link
Contributor

Seems like a bug on the GCP side - that permission should be included in the existing roles, but no predefined role includes it. Let me see what can be done about that.

@knapo
Copy link

knapo commented Oct 15, 2019

Mind posting your diff so I can make sure it's expected?

Sure:

Screenshot 2019-10-15 at 09 59 56

@nat-henderson
Copy link
Contributor

Thanks! I consider that expected, but I see that it's causing problems since you can't find the permission you need to be able to make that change. I'll keep digging on that.

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants