Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Cloud Run DomainMapping namespace in encoder #4657

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Oct 10, 2019

Original Author: @rileykarson

`cloudrun`: fixed the apiVersion sent in `google_cloud_run_domain_mapping` requests

Signed-off-by: Modular Magician <magic-modules@google.com>
@rileykarson
Copy link
Collaborator

Unrelated PR, just some Magician thrashing.

@rileykarson rileykarson merged commit b15b6a6 into hashicorp:master Oct 10, 2019
@ghost
Copy link

ghost commented Nov 10, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants