Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigtable Instance changes #5648

Conversation

modular-magician
Copy link
Collaborator

  • instance_type and display_name are now updatable
  • don't detect drift on instance_type to prepare for API changes
  • get rid of customdiff for development instances because they sort of compare against config but sort of compare against state and I just think we're going to see more problems with it down the line especially if there are upcoming API changes

Release Note Template for Downstream PRs (will be copied)

* bigtable: added update support for `display_name` and `instance_type`

Derived from GoogleCloudPlatform/magic-modules#3102

* make instancetype and displayname updatable, stop detecting drift on instancetype

* update tests

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/m label Feb 11, 2020
@modular-magician modular-magician merged commit d279255 into hashicorp:master Feb 11, 2020
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant