Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google project precheck #5719

Conversation

modular-magician
Copy link
Collaborator

closes #5671 as it's the upstream pr.
fixes #5222
references terraform-google-modules/terraform-google-project-factory#373

Release Note Template for Downstream PRs (will be copied)

compute: Updated `google_project` to check for valid permissions on the parent billing account before creating and tainting the resource.

Derived from GoogleCloudPlatform/magic-modules#3145

* project: check for billing account perms as pre-requisite

* outdent

* typo

* rm type from error message

* simplify perms check

* simplify bool check

* simplify bool check

Co-authored-by: Umair Idris <umairidris93@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xs label Feb 19, 2020
@modular-magician modular-magician merged commit 6494ef4 into hashicorp:master Feb 19, 2020
@ghost
Copy link

ghost commented Mar 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project is getting tainted in TF state file, even though it got created; when billing id is incorrect
1 participant