Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Engine Service Split Traffic resource #5729

Conversation

modular-magician
Copy link
Collaborator

  • Added custom_create in custom_code.
  • Added appengine service resource

Release Note for Downstream PRs (will be copied)

`google_app_engine_service_split_traffic`

Derived from GoogleCloudPlatform/magic-modules#2269

* Appengine Service resource

* Added custom_create in custom_code.
* Added appengine service resource

* Updates based on review

* Updates based on review

* update based on review

* Updates

* Update

* Update

* Updated the example

* Updated the example and website link

* Skip Delete on test and noop

* Rebased and merged the appengine terraform.yaml

* Updates

* Fixes

* updated the example and excluded split from reading

* updated the example

* Reverted custom_create related code

* Reverted resource.erb

* updates

* removed the error check

* Updates

* Fixes

* Fixed the import in test script

* Updates as per review

* chanded the operation to OpAsync

* Updated the Objects from Async to OpAsync

* Fixed the example primary resource name

* Testing by removing id_format and import_format

* reverted import and id format and also the example

* Fixed the id_format

* Updates based on review

* Typo fix

* Changed url_param_only to api_name

* Updated the resource.erb from upstream/master

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 36c5e6f into hashicorp:master Feb 20, 2020
@ghost
Copy link

ghost commented Mar 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant