Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 404-retries for pubsub and poll async utils #5813

Conversation

modular-magician
Copy link
Collaborator

  • Add PollWaitTime util for generic polling
  • Add PollWaiter interface and changed Cloud Run polling to match
  • Added two generic PollWaiters, one for 404-checking and one for matching state
  • Added PollAsync to pubsub

Release Note Template for Downstream PRs (will be copied)

pubsub: Add polling to ensure correct resource state for negative-cached PubSub resources 

Fixes GoogleCloudPlatform/magic-modules#3155

Derived from GoogleCloudPlatform/magic-modules#3155

* refactor async and pollasync, add to pubsub

* remove unintended whitespace changes

* license, spacing

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 86445d5 into hashicorp:master Mar 2, 2020
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant