Allow passwords and tokens to be sensitive #5873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow passwords and tokens to be sensitive Notification channels are configured by sending tokens and passwords via labels. This change allows the sensitive labels to be configured in a separate block so that they can be marked as Sensitive and hidden from plan output. Encoders and Decoders are used to manipulate the labels block before it is passed to the expanders/flatteners. The token can be specified in either place right now, but the intent is to remove the ability to manage these from being managed via the "labels" block in the next breaking change. * update description and remove old files * Add sensitive label example Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notification channels are configured by sending tokens and passwords via
labels. This change allows the sensitive labels to be configured in a
separate block so that they can be marked as Sensitive and hidden from plan
output. Encoders and Decoders are used to manipulate the labels block before
it is passed to the expanders/flatteners.
The token can be specified in either place right now, but the intent is to
remove the ability to manage these from being managed via the "labels" block
in the next breaking change.
fixes #5369
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3177