Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for VpcConnectorEgressSettings field to cloudfunctions… #5984

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Adding support for VpcConnectorEgressSettings field to cloudfunctions… #5984

merged 1 commit into from
Mar 27, 2020

Conversation

jambt
Copy link
Contributor

@jambt jambt commented Mar 26, 2020 •
edited by rileykarson

…. Also Updating the website docs for terraform.

  • Adding support for VpcConnectorEgressSettings field to cloudfunctions.

  • Updating the webiste docs for terraform.

`cloudfunctions`: added support for `vpc_connector_egress_settings` to `google_cloudfunctions_function`

@ghost ghost added the size/xs label Mar 26, 2020
@ghost ghost requested review from rileykarson March 26, 2020 11:02
@ghost ghost added the documentation label Mar 26, 2020
@jambt
Copy link
Contributor Author

jambt commented Mar 26, 2020

Hi there,

I followed the PR #5981 to implement a missing setting for the vpc egress. Feel free to criticize or improve, since this is my first contribution.

rileykarson
rileykarson reviewed Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just a few small things.

google/resource_cloudfunctions_function.go Outdated Show resolved Hide resolved
google/resource_cloudfunctions_function.go Outdated Show resolved Hide resolved
website/docs/r/cloudfunctions_function.html.markdown Outdated Show resolved Hide resolved
website/docs/d/datasource_cloudfunctions_function.html.markdown Outdated Show resolved Hide resolved
google/resource_cloudfunctions_function.go Show resolved Hide resolved
Adding support for VpcConnectorEgressSettings field to cloudfunctions…
f232689 
…. Also Updating the website docs for terraform.

* Adding support for VpcConnectorEgressSettings field to cloudfunctions.

* Updating the webiste docs for terraform.
@jambt
Copy link
Contributor Author

jambt commented Mar 27, 2020

Hi @rileykarson,

thank you for the very valid corrections. I implemented them all. Furthermore, I removed the line const functionDefaultVpcConnectorEgressSettings = "VPC_CONNECTOR_EGRESS_SETTINGS_UNSPECIFIED" since it is now obsolete.

Can something further be improved?

rileykarson
rileykarson approved these changes Mar 27, 2020
View reviewed changes
Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for your contribution.

I'm going to upstream this change to our code generator, Magic Modules, before merging, so that the change makes it to google-beta as well.

@rileykarson rileykarson mentioned this pull request Mar 27, 2020
Merged
@rileykarson rileykarson merged commit fff9fcb into hashicorp:master Mar 27, 2020
This was referenced Mar 27, 2020
Merged
Merged
@gal432 gal432 mentioned this pull request Apr 26, 2020
Closed
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
documentation size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jambt @rileykarson