Standardize google_compute_instance import

[jcanseco]

This patch changes the import ID of google_compute_instance to have a
format that is more consistent with other resources like
google_compute_subnetwork while still supporting the previously
supported import ID of {{project}}/{{zone}}/{{name}} in order to have
backwards compatibility.

compute: Added more import formats for `google_compute_instance`

[emilymye]

Hi @jcanseco. Thanks for submitting! We'll go ahead and upstream this for you. In the future, if you want to do a similar change, it saves us a bit of work if you do so against MM. In this case, since instance is still a handwritten resource, it'd be these files.

Otherwise for autogenerated resources, it'd be in our terraform.yaml (see import_format, example) or inferred from the id format. Not sure if you might have already known, but just in case!

[jcanseco]

Hi @emilymye thanks, the links are helpful. I'll make sure to apply changes to Magic Modules next time. In the meantime, I hope it's ok if I keep my last remaining PR open in this repo (I'm in the process of addressing its comments currently).

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!