Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init os-login sshkey #6026

Conversation

modular-magician
Copy link
Collaborator

Create new terraform resource oslogin SSHPublicKey

#5389

  • Use-case 1: add the ssh public key on current the user defined on the provider
    User email is set by default with the current userinfO
  • Use-case 2: add the ssh public key on a specific user
    User email is provided with impersonated provider and google_client_openid_userinfo
    example here

Release Note Template for Downstream PRs (will be copied)

`google_os_login_ssh_public_key`

Derived from GoogleCloudPlatform/magic-modules#3221

* init os-login sshkey

Signed-off-by: Sébastien GLON <sebglon@gmail.com>

* Fix naming + example

* Fix endpoint

* clean build folder

* Apply suggestions from code review

Co-Authored-By: Riley Karson <rileykarson@google.com>

* Fix review

* Add post_create

* Add reference doc

* Try to put user on url request

* Fix user

* Get the default userinfo email

* Update products/oslogin/api.yaml

Co-Authored-By: Riley Karson <rileykarson@google.com>

* Apply suggestions from code review

* revert url_param_only

* creation fixed

* Work except import

* Add id_format and import_format

* Add Id

* Fix id

* Update source_repo_repository_update.go.erb

* Update source_repo_repository_update.go.erb

* revert

* Apply suggestions from code review

Co-Authored-By: Riley Karson <rileykarson@google.com>

* Add sidebar link

Co-authored-by: Sébastien GLON <sebglon@gmail.com>
Co-authored-by: Riley Karson <rileykarson@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 7c94263 into hashicorp:master Apr 1, 2020
@ghost
Copy link

ghost commented May 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant