Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bigquery_dataset_access fine-grained resource #6035

Conversation

modular-magician
Copy link
Collaborator

Fixes #2686

Includes some changes to nested query func names so they don't conflict with the ones from the parent resource.

Also includes changes to the function that finds matches in nested query: now, instead of comparing the expanded form from the config to the flattened form from the API, it compares the expanded-and-then-flattened form from the config to the flattened form from the API. Without this, we end up comparing a config format (e.g. user_by_email) to the API format (e.g. userByEmail)

Release Note Template for Downstream PRs (will be copied)

`google_bigquery_dataset_access`

Derived from GoogleCloudPlatform/magic-modules#3312

* add bigquery_dataset_access fine-grained resource

* exclude ansible and inspec

* exclude validator

* compile

* expand and flatten when checking match

* add mutex and multiple test

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit f3c888b into hashicorp:master Apr 3, 2020
@ghost
Copy link

ghost commented May 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bigquery dataset view access creates circular dependency
1 participant