Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monitoring service resource, datasource for app engine #6078

Conversation

modular-magician
Copy link
Collaborator

Based on API errors, only custom monitoring Service resources can be created manually.

This adds:

This is first in set of PRs. Next PRs will:

  • Add SLO resource
  • Add other datasources google_monitoring_cloud_endpoints_service, google_monitoring_mesh_istio_service, etc: This needs extra resources outside of GCP/monitoring to test, so I'm excluding them until I figure out how to get testing resources for them.

Things to consider:

  • Right now the resource (custom service) can't even be created in UI and is not used for anything. I'd be ok with removing it so people aren't confused, but I wanted to have the resource schema for the datasource (since resource schema is autogenerated)
  • This adds a new datasource per GCP-managed service type. I chose this path because each identifier block can be fairly involved (see meshIstio) and filtering on a specific block in the datasource to determine which filters to call in for the list() API endpoint

Release Note Template for Downstream PRs (will be copied)

`google_monitoring_custom_service`
`google_monitoring_app_engine_service`

Derived from GoogleCloudPlatform/magic-modules#3341

…#3341)

* initial monitoring custom service resource

* add datasource for monitoring service

* lint

* add update mask

* add optional project to monitoring service data source

* fmt

* review changes

* rename  resource in test

* edit vars, use custom import

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit e820eaf into hashicorp:master Apr 8, 2020
@ghost
Copy link

ghost commented May 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant