Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fields to be removed at a specific version #6193

Conversation

modular-magician
Copy link
Collaborator

The healthcare API has deprecated a field at beta and removed it from the GA
launch of the api. In order to support this without having to duplicate the
entire resource this change supports defining a single field multiple times
with a different configruation for each version. Specifically it allows a field
to exist as deprecated at one version but not at another.
This also introduces the removed_message field.

This is another follow on to GoogleCloudPlatform/magic-modules#3377 which GA'ed this resource without addressing the removed fields.

TODO - this change requires vendoring changes in both downstream repos.

Release Note Template for Downstream PRs (will be copied)

`google_healthcare_dataset` is now GA
`google_healthcare_dicom_store` is now GA
`google_healthcare_fhir_store` is now GA
`google_healthcare_hl7_v2_store` is now GA
`google_healthcare_dataset_iam_binding` is now GA
`google_healthcare_dataset_iam_member` is now GA
`google_healthcare_dataset_iam_policy` is now GA
`google_healthcare_dicom_store_iam_binding` is now GA
`google_healthcare_dicom_store_iam_member` is now GA
`google_healthcare_dicom_store_iam_policy` is now GA
`google_healthcare_fhir_store_iam_binding` is now GA
`google_healthcare_fhir_store_iam_member` is now GA
`google_healthcare_fhir_store_iam_policy` is now GA
`google_healthcare_hl7_v2_store_iam_binding` is now GA
`google_healthcare_hl7_v2_store_iam_member` is now GA
`google_healthcare_hl7_v2_store_iam_policy` is now GA

Derived from GoogleCloudPlatform/magic-modules#3417

The healthcare API has deprecated a field at beta and removed it from the GA
launch of the api. In order to support this without having to duplicate the
entire resource this change supports defining a single field multiple times
with a different configruation for each version. Specifically it allows a field
to exist as deprecated at one version but not at another.
This also introduces the removed_message field.

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 01a086e into hashicorp:master Apr 24, 2020
@ghost
Copy link

ghost commented May 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant