Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't include IGM URLs that 404 in instance_group_urls #6242

Conversation

modular-magician
Copy link
Collaborator

Fixes #4314.

Tested by creating a cluster and node pools, deleting one of the created IGs in the cloud console, and running terraform refresh.

Release Note Template for Downstream PRs (will be copied)

* container: fixed issue where terraform would error if a gke instance group was deleted out-of-band

Derived from GoogleCloudPlatform/magic-modules#3438

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xs label Apr 29, 2020
@modular-magician modular-magician merged commit 8b9e43c into hashicorp:master Apr 29, 2020
@ghost
Copy link

ghost commented May 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If an instance group managed by a GKE node pool is manually removed, terraform plan fails to refresh
1 participant