Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataflow job update-by-replacement #6257

Conversation

modular-magician
Copy link
Collaborator

Fixes #5991

  • Adds update-by-replacement method
  • Separates ForceNew functionality based on JOB_TYPE
  • Triggers diffs based on reading the new template_md5hash

Release Note Template for Downstream PRs (will be copied)

dataflow: Added support for update-by-replacement to `google_dataflow_job`
dataflow: Added drift detection for `google_dataflow_job` `template_gcs_path` and `temp_gcs_location` fields

Derived from GoogleCloudPlatform/magic-modules#3387

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/l label Apr 30, 2020
@modular-magician modular-magician merged commit 464d3db into hashicorp:master Apr 30, 2020
@ghost
Copy link

ghost commented May 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Dataflow job "update-by-replacement"
1 participant