Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GKE release channel updates #6373

Conversation

modular-magician
Copy link
Collaborator

Fixes #5846

The field I exposed on the datasource doesn't match the API 1:1 (which is a list of objects. repeated message in proto, I bet), but should prove much more useful overall- as you can see in the test, it's simple to look up the version for the channel and advance to it.

Release Note Template for Downstream PRs (will be copied)

container: added update support to `google_container_cluster`'s `release_channel` field (`google-beta` only)
container: added the ability to unspecify `google_container_cluster`'s `min_master_version` field
container: added `release_channel_default_version` to `data.google_container_engine_versions`, allowing you to find the default version for a release channel (`google-beta` only)

Derived from GoogleCloudPlatform/magic-modules#3509

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 0c45905 into hashicorp:master May 13, 2020
@ghost
Copy link

ghost commented Jun 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add update support for google_container_cluster.release_channel
1 participant