Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow update of node pool workload metadata config #6430

Conversation

modular-magician
Copy link
Collaborator

Release Note Template for Downstream PRs (will be copied)

container: Added update support for `node_config.workload_metadata_config` to `google_container_node_pool`

Fixes #4041

This field is only updatable on node pool, so we've chosen to only make it updatable on node_pool and keep it ForceNew on container cluster

In addition, because cluster.workload_identity_config and node_pool.workload_metadata_config are closely related, I decided to combine the test

Derived from GoogleCloudPlatform/magic-modules#3512

* update of node pool workload metadata

* fix forcenew for nested field as well

* add set to util for forcenewing field schema, move to utils

* add back forcenew for sandbox config

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xl label May 20, 2020
@modular-magician modular-magician merged commit ae7247f into hashicorp:master May 20, 2020
@ghost
Copy link

ghost commented Jun 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update workload_metadata_config.node_metadata on node pools without force replacement.
1 participant