Ensure Elem is always either a *Schema or *Resource #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmy-btn
force-pushed
the
jimmy/fix-schemas
branch
from
df01155
to
e478e97
Compare
|
Thanks @jimmy-btn! |
jimmy-btn
added a commit
to jimmy-btn/terraform-provider-google
that referenced
this pull request
Jan 12, 2018
rosbo
pushed a commit
that referenced
this pull request
Jan 12, 2018
modular-magician
added a commit
to modular-magician/terraform-provider-google
that referenced
this pull request
Sep 27, 2019
Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares this provider for hashicorp/terraform#17037, which will cause Provider.InternalValidate to reject schemas which assign invalid types (anything other than a *Schema or a *Resource) to the Elem field of a Schema.
This mostly addresses issues where the expected type for a Map is provided directly rather than wrapped in schema.Schema{}. Today this is a non-issue, but will cause problems in the future if we enforce type checking on Map types.