This repository has been archived by the owner on Dec 5, 2020. It is now read-only.
Allow users to omit the optional verification hashes #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grubernaut
approved these changes
Jul 31, 2017
| func TestIngnitionFileAppendNoVerification(t *testing.T) { | ||
| testIgnition(t, ` | ||
| data "ignition_config" "test" { | ||
| append { |
There was a problem hiding this comment.
minor nit: odd spacing here
There was a problem hiding this comment.
That one was copied down from the original tests :)
I've changed them all to tabs so they should look nice.
ignition/resource_ignition_file.go
Outdated
| h, err := buildHash(d.Get("source.0.verification").(string)) | ||
| if err != nil { | ||
| return "", err | ||
| verification := d.Get("source.0.verification").(string) |
There was a problem hiding this comment.
Can use the helper function GetOk() here. ie:
if v, ok := d.GetOk("source.0.verification"); ok {
h, err := buildHash(v.(string))
if err != nil {
return "", err
}
hash = &h
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the configuration spec
verificationis optional for files and configuration append/replace sources.This PR does only push the
Hashback into the ignition configuration if the verification option was set in the terraform configuration. That way the config validation does not throwmalformed hash specifiererrors if one would omit the verification option.