Skip to content
This repository has been archived by the owner on Nov 14, 2020. It is now read-only.

postgresql_role: Add roles attribute. #52

Conversation

cyrilgdn
Copy link
Contributor

This allows to grant roles to the role we are managing.

Example:

resource postgresql_role "test_group" {
  name = "test_group"
}

resource postgresql_role "test_role" {
  name  = "test_role"
  roles = ["${postgresql_role.test_group.name}"]
}

Fix #21

This probably conflicts with #23

@ghost ghost added the size/XL label Nov 23, 2018
@cyrilgdn cyrilgdn force-pushed the upstream-postgresql_role-attr-roles branch from ee334e1 to c8d5737 Compare December 5, 2018 14:51
@cyrilgdn cyrilgdn force-pushed the upstream-postgresql_role-attr-roles branch 2 times, most recently from 3f3a564 to 049a0f6 Compare January 14, 2019 22:47
@evgmoskalenko
Copy link

@cyrilgdn, Hello, tell me please, when the release is expected?

@cyrilgdn
Copy link
Contributor Author

cyrilgdn commented Feb 8, 2019

@evgmoskalenko I'm currently looking for reviews for all my PRs, as soon as they get merged I'll try to create a new release.
My goal is to do it as soon as possible but unfortunately I can't give you a date.
However, you can watch the repository in the new "Releases only" mode so you'll be notified

@cyrilgdn cyrilgdn force-pushed the master branch 2 times, most recently from 9c127f8 to 62ab8f1 Compare February 20, 2019 21:43
@cyrilgdn cyrilgdn added the WIP label Mar 1, 2019
@cyrilgdn cyrilgdn force-pushed the upstream-postgresql_role-attr-roles branch 2 times, most recently from 5ce1039 to b022254 Compare March 4, 2019 20:55
@cyrilgdn cyrilgdn removed the WIP label Mar 4, 2019
@cyrilgdn cyrilgdn force-pushed the upstream-postgresql_role-attr-roles branch 2 times, most recently from 9c58fd1 to b084d49 Compare April 1, 2019 06:56
Copy link
Contributor

@multani multani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyrilgdn I tried the code from this PR, it seems to work as advertised, the tests look good to me and I tried to make it break without success :)

Hopefully this can get merged and released really soon!

As a side node: As said previously, while testing this PR, I saw lot of connections/disconnections on the PostgreSQL server, while applying this type of change - it's not specifically due to this patch though but I guess this could be looked into.

* This allows to grant roles to the role we are managing.
@cyrilgdn cyrilgdn force-pushed the upstream-postgresql_role-attr-roles branch from b084d49 to 834fd19 Compare April 21, 2019 14:24
@ghost ghost added the documentation label Apr 21, 2019
@cyrilgdn
Copy link
Contributor Author

Thanks @multani , I've just added the documentation for the website (which I forgot).

Good remark for the connections number, it's the case for multiple resources, I'll try to enhance these behaviors in the future.

@cyrilgdn cyrilgdn merged commit 056cde6 into hashicorp:master Apr 21, 2019
@cyrilgdn cyrilgdn deleted the upstream-postgresql_role-attr-roles branch April 21, 2019 14:27
@ixalon
Copy link

ixalon commented May 7, 2019

@cyrilgdn - this feature is exactly what I was looking for today (to grant the rds_iam role to enable IAM authentication when running on AWS RDS). Thank you!

Any idea when you’ll be able to roll a release with this feature?

@cyrilgdn
Copy link
Contributor Author

cyrilgdn commented May 8, 2019

@ixalon I'll try to release a version this week

@jaypz
Copy link

jaypz commented May 15, 2019

@cyrilgdn
Any update on when to expect this release? Thanks!

@cyrilgdn
Copy link
Contributor Author

@jaypz Yes sorry, didn't take the time to do it as announced .

I've just asked to create the 0.4.0 release. It should be good for tomorrow (except if any troubles with the release process).
I'll let you know here when it's good. You can also watch (if it's not already the case) this repository in the "Releases only" mode to be alerted as soon as it's released.

@cyrilgdn
Copy link
Contributor Author

@jaypz @ixalon Actually it's already released 👍 (thanks to Terraform developers which have been very fast !)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create role_membership resource
5 participants