Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #39 - panic for corrupt private keys in tls_public_key #40

Merged
merged 3 commits into from
Aug 16, 2019

Conversation

harryrose
Copy link
Contributor

@harryrose harryrose commented Jan 14, 2019

Provides a fix + tests for a panic that occurs when the private key pem is corrupt

@ghost ghost added the size/XS label Jan 14, 2019
@apparentlymart
Copy link
Member

Thanks @harryrose!

I have removed the CHANGELOG part of your changeset because we generally do that only after merging so that the CHANGELOG doesn't become conflicted immediately after each merge, but I'm otherwise going to merge this as-is once the tests finish running.

@apparentlymart apparentlymart merged commit cd092b2 into hashicorp:master Aug 16, 2019
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants