tls: mark all fields with private keys as sensitive #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform >= 0.12.0 shows all resource fields during planning, so all generated private keys my end up in STDOUT/logs, which is potential security threat. This commit sets Sensitive: true to all fields which store private keys. Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
ghost
added
the
|
Thanks for working on this, @invidian! I'm surprised that this is new behavior in 0.12, since 0.11 should've been printing out the values it was writing for these too, but indeed there's no reason why these should not be marked as |
|
Thanks! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform >= 0.12.0 shows all resource fields during planning, so
all generated private keys my end up in STDOUT/logs, which is potential
security threat.
This commit sets Sensitive: true to all fields which store private keys.
Signed-off-by: Mateusz Gozdek mgozdekof@gmail.com