Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements #49 - add support for subject alternative name URIs #50

Merged
merged 2 commits into from
Aug 16, 2019

Conversation

subnova
Copy link
Contributor

@subnova subnova commented Jun 19, 2019

Adds a field uris to the resources:

  • tls_self_signed_cert
  • tls_cert_request

That allow subject alternative names of type 'uri' to be set on a certificate. This is analogous to the 'dns_names' and 'ip_addresses' fields.

Modifies the tls_locally_signed_cert resource to copy the URIs from the cert request to the generated certificate.

@apparentlymart
Copy link
Contributor

Hi @subnova! Thanks for working on this, and sorry for the slow response.

This looks good to me, so I'm going to merge it now for inclusion in the next release.

@apparentlymart apparentlymart merged commit 59ab214 into hashicorp:master Aug 16, 2019
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants