Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a data source for reading attributes from a servers certificate chain #62

Merged
merged 3 commits into from
Jul 24, 2020
Merged

Add a data source for reading attributes from a servers certificate chain #62

merged 3 commits into from
Jul 24, 2020

Conversation

wjam
Copy link
Contributor

@wjam wjam commented Nov 8, 2019

Fixes #4 and #52.

@wjam
Copy link
Contributor Author

wjam commented Nov 13, 2019

@appilon @apparentlymart @radeksimko Is this okay to be reviewed?

@wjam
Copy link
Contributor Author

wjam commented Nov 21, 2019

@apparentlymart @radeksimko @appilon Is this change okay to be reviewed/merged?

@wjam
Copy link
Contributor Author

wjam commented Jan 3, 2020

@apparentlymart @radeksimko @appilon Any update on review this PR?

@wjam
Copy link
Contributor Author

wjam commented Apr 12, 2020

@apparentlymart @radeksimko @appilon Is there any chances of getting this reviewed?

@rabidscorpio
Copy link

This would allow a completely automated setup of an EKS cluster without the need to run an external script and allow hashicorp/terraform-provider-aws#10104 to be closed, an issue that's been around for 8 months now. @apparentlymart @radeksimko @appilon Please take a look at this.

@asmfis
Copy link

asmfis commented May 18, 2020

hello, wonder if there is any update on this? do you need help with approving / reviewing it @apparentlymart @radeksimko @appilon?

@kmoe kmoe self-assigned this Jun 26, 2020
kmoe
kmoe suggested changes Jun 28, 2020
View reviewed changes
Copy link
Member

@kmoe kmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @wjam - this is a great contribution. Some minor changes to make after review, then we'll be pleased to include this in the TLS provider.

tls/data_source_tls_certificate.go Outdated
u.Host += ":443"
}

conn, err := tls.Dial("tcp", u.Host, &tls.Config{InsecureSkipVerify: true})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an optional verify_chain attribute (defaulting to true) to allow users to configure this, then set it to false during testing.

website/tls.erb Outdated Show resolved Hide resolved
tls/test_fixtures/tls_certs/private.pem Outdated
@@ -0,0 +1,27 @@
-----BEGIN RSA PRIVATE KEY-----
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename test_fixtures directory to testdata following Go convention.

wjam and others added 2 commits June 28, 2020 18:21
@wjam @kmoe
Update website/tls.erb
373b388 
Co-authored-by: kmoe <5575356+kmoe@users.noreply.github.com>
@wjam
Changes from code review
3e5ce49 
* Rename test_fixtures to testdata
* Add verify_chain attribute
@wjam
Copy link
Contributor Author

wjam commented Jun 28, 2020

@kmoe Changes pushed

@bflad bflad mentioned this pull request Jun 30, 2020
Closed
@wjam wjam requested a review from kmoe July 4, 2020 16:20
@nickatsegment nickatsegment mentioned this pull request Jul 14, 2020
Closed
@kmoe kmoe merged commit db594cb into hashicorp:master Jul 24, 2020
@kmoe kmoe mentioned this pull request Jul 24, 2020
Closed
@wjam wjam deleted the data_tls_certificate branch July 25, 2020 18:31
@nnsense nnsense mentioned this pull request May 31, 2021
Merged
nitrocode pushed a commit to cloudposse/terraform-aws-eks-cluster that referenced this pull request Jun 4, 2021
@nnsense @cloudpossebot @aknysh
OIDC thumbprint_list can be retrieved and tags added to OIDC provider (…
361f8a9 
…#115)

* - Tags added to the OIDC provider
- With hashicorp/terraform-provider-tls#62 sha1_fingerprint can be retrieved instead of hardcoding it (which isn't safe as not all regions have the same)

* tls version set

* Auto Format

* Adding count to data source

* Update main.tf

Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>

* Auto Format

Co-authored-by: Matteo Migliaccio <matteo.migliaccio@geospock.com>
Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@dttung2905 dttung2905 mentioned this pull request Dec 22, 2021
Closed
This was referenced Apr 13, 2023
Closed
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kmoe kmoe kmoe approved these changes

Assignees

@kmoe kmoe

Labels
documentation size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: New data source for TLS cert
4 participants
@wjam @rabidscorpio @asmfis @kmoe