Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.3.0 has a breaking change in vault_generic_secret #229

Closed
lattwood opened this issue Nov 6, 2018 · 6 comments
Closed

Version 1.3.0 has a breaking change in vault_generic_secret #229

lattwood opened this issue Nov 6, 2018 · 6 comments

Comments

@lattwood
Copy link

lattwood commented Nov 6, 2018

The preflight checks for vault_generic_secret accesses /v1/sys/internal/ui/mounts/$PATH, and it checks for a 404 StatusCode to determine whether fallback behaviour should be used.

Unfortunately, this path returns a 403 StatusCode on Vault 0.8.3, and not a 404 as expected.

References

@tyrannosaurus-becks
Copy link
Contributor

@lattwood can you link to where the 403 check is needed or submit a PR? If so I can get a v1.3.1 binary out on the sooner side.

@lattwood
Copy link
Author

lattwood commented Nov 6, 2018

@DonBower
Copy link

DonBower commented Nov 6, 2018

we have discovered the same issue, with vault 0.9.5

@tyrannosaurus-becks
Copy link
Contributor

@lattwood thanks!

@lattwood
Copy link
Author

lattwood commented Nov 6, 2018

Thanks @tyrannosaurus-becks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants