Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for VAULT_TLS_SERVER_NAME #1145

Merged
merged 2 commits into from Apr 20, 2022
Merged

feat: support for VAULT_TLS_SERVER_NAME #1145

merged 2 commits into from Apr 20, 2022

Conversation

greut
Copy link
Contributor

@greut greut commented Aug 11, 2021 •
edited by benashz

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #300

Release note for CHANGELOG:

FEATURES:
* `provider`: Add support for `tls_server_name` to use as the SNI host when connecting via TLS.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@greut greut marked this pull request as ready for review August 23, 2021 14:00
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@sfc-gh-swinkler
Copy link

i was about to make a PR for this as well but seeing how you already made one but it never got approved is troubling...

@greut
feat: support for VAULT_TLS_SERVER_NAME
b27921d 
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
@benashz benashz self-requested a review April 20, 2022 13:06
benashz
benashz reviewed Apr 20, 2022
View reviewed changes
vault/provider.go Outdated Show resolved Hide resolved
@benashz benashz added this to the 3.5.0 milestone Apr 20, 2022
benashz
benashz approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank your for your contribution to HashiCorp!

@benashz benashz merged commit 837b143 into hashicorp:main Apr 20, 2022
@greut greut deleted the feat/tls-server-name branch April 23, 2022 13:35
@greut greut restored the feat/tls-server-name branch April 23, 2022 13:35
@greut greut deleted the feat/tls-server-name branch April 23, 2022 13:36
@greut greut restored the feat/tls-server-name branch April 23, 2022 13:36
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
@greut @benashz
support for VAULT_TLS_SERVER_NAME (hashicorp#1145)
07d4b40 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
documentation size/XS
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

feature request: support VAULT_TLS_SERVER_NAME in provider config
4 participants
@greut @hashicorp-cla @sfc-gh-swinkler @benashz