r/database_secret_backend_configuration - elasticsearch missing fields

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource/database_secret_backend_configuration - add missing elasticseach fields

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDatabaseSecretBackendConnection_elasticsearch'

--- PASS: TestAccDatabaseSecretBackendConnection_elasticsearch (27.07s)

[DrFaust92]

@benashz, I have a feeling Import is broken after the plugin name refactor.

Im getting

Error: no supported database engines configured


    resource_database_secret_backend_connection_test.go:703: Step 2/2 error running import: exit status 1
        
        Error: no supported database engines configured

Ive removed the import check for now but i think that

	db, err := getDBEngine(d)
	if err != nil {
		return err
	}

needs to be moved after the the the actual read calls as on import you only have the id of the resource available.

[benashz]

Thanks @DrFaust92. Good catch. We will address this before the upcoming 3.3.0 release.

[benashz]

@DrFaust92 currently all import tests are passing. Is the error specific to this PR?

[benashz]

@DrFaust92 Actually scratch that. I can reproduce it now.

[DrFaust92]

@benashz, LMK if you need any help with that :D

[benashz]

Thanks @DrFaust92 , I have a PR here #1348

[hashicorp-cla]

All committers have signed the CLA.

[DrFaust92]

@benashz rebased

[benashz]

Looking good! I think we only need to look at adding the new fields to the acceptance tests.

[benashz]

LGTM!

Thanks again for your contribution to HashiCorp!