Allow for overriding the tenant and subscription IDs. #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TechyMatt
reviewed
Mar 24, 2022
| @@ -134,19 +146,25 @@ func azureAccessCredentialsDataSourceRead(d *schema.ResourceData, meta interface | |||
| log.Printf("[DEBUG] Successfully read %q from Vault", configPath) | |||
|
|
|||
| subscriptionID := "" | |||
| if subscriptionIDIfc, ok := config.Data["subscription_id"]; ok { | |||
| if v, ok := d.GetOk("subscription_id"); ok { | |||
There was a problem hiding this comment.
Can you set line 142 that if subscription id and tenant id are defined in the provider then it doesn't need to do the vault config read at all? I don't believe it's used anywhere else in the code and would mean the token that is being used by terraform can have fewer permissions in vault as it no longer needs to read the config.
vinay-gopalan
approved these changes
Mar 24, 2022
vinay-gopalan
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The best description for this PR can be found here: #1381 (comment)
Community Note
Relates OR Closes #0000
Release note for CHANGELOG:
Output from acceptance testing: