Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PKI certificate revocation support #1411

Merged
merged 4 commits into from Apr 12, 2022

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Apr 11, 2022

A new configuration option revoke can be applied to the
vault_pki_secret_backend_cert resource. In the case where it is set to
to true, the certificate will be revoked via Vault's PKI certificate
revocation API.

Community Note

  • Please vote on this pull request by adding a 馃憤 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #719

Release note for CHANGELOG:


Output from acceptance testing:

$ make testacc TESTARGS='-v -test.run TestPkiSecretBackendCert*'        

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./...) -v -v -test.run TestPkiSecretBackendCert* -timeout 20m

=== RUN   TestPkiSecretBackendCert_basic
--- PASS: TestPkiSecretBackendCert_basic (5.79s)
=== RUN   TestPkiSecretBackendCert_revoke
--- PASS: TestPkiSecretBackendCert_revoke (5.89s)
=== RUN   TestPkiSecretBackendCert_renew
--- PASS: TestPkiSecretBackendCert_renew (9.07s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     22.040s



...

jesmg and others added 2 commits October 31, 2021 03:26
A new configuration option `revoke` can be applied to the
vault_pki_secret_backend_cert resource. In the case where it is set to
to true, the certificate will be revoked via Vault's PKI certificate
revocation API.
@benashz benashz merged commit 0a9e825 into main Apr 12, 2022
@benashz benashz deleted the VAULT-5593/pki-support-cert-revocation branch April 12, 2022 13:52
@benashz benashz added this to the 3.5.0 milestone Apr 12, 2022
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
A new configuration option revoke can be applied to the
vault_pki_secret_backend_cert resource. In the case where it is set to
to true, the certificate will be revoked via Vault's PKI certificate
revocation API.

Co-authored-by: Jes煤s Mar铆n <contacto@jesusmg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Revoke cert automatically when vault_pki_secret_backend_cert resource is destroyed.
3 participants