Add param to configure uri_sans for CSRs #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Thanks @mdgreenfield ! This PR still needs test coverage and a doc update. Contributing has some info on that. I'll take a closer look when those are done. |
|
Thanks for pointing me to that. I've added a test and updated the docs. |
|
Thanks for adding that test, it looks like it's hitting the PR's code path! I will take a second look at this once the test is passing. Definitely a step in the right direction. |
mdgreenfield
force-pushed
the
fix-csr-uri-sans
branch
from
d7328ee
to
dd6fab0
Compare
|
Thanks @tyrannosaurus-becks. Tests are passing now. I see 1.7.0 was just released 2 days ago. Bummer I didn't get this fixed in time. Any idea when the next release to include these changes will be? |
tyrannosaurus-becks
approved these changes
Apr 26, 2019
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
Add param to configure uri_sans for CSRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #372