Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic when trying to write an entity alias that already exists #573

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Fix panic when trying to write an entity alias that already exists #573

merged 2 commits into from
Nov 1, 2019

Conversation

kalafut
Copy link
Contributor

@kalafut kalafut commented Oct 23, 2019

Fixes #523

@ghost ghost added the size/S label Oct 23, 2019
catsby
catsby reviewed Oct 24, 2019
View reviewed changes
Copy link
Member

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about behavior

vault/resource_identity_entity_alias.go Outdated Show resolved Hide resolved
@tyrannosaurus-becks tyrannosaurus-becks self-assigned this Oct 29, 2019
tyrannosaurus-becks
tyrannosaurus-becks approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for working on this!

vault/resource_identity_entity_alias.go Show resolved Hide resolved
vault/resource_identity_entity_alias.go Show resolved Hide resolved
vault/resource_identity_entity_alias.go Show resolved Hide resolved
@kalafut kalafut merged commit f203b29 into master Nov 1, 2019
@kalafut kalafut deleted the fix-entity-alias-panic branch November 1, 2019 16:05
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Fix panic when trying to write an entity alias that already exists (h…
1f265e3 
…ashicorp#573)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catsby catsby catsby left review comments

@tyrannosaurus-becks tyrannosaurus-becks tyrannosaurus-becks approved these changes

Assignees

@tyrannosaurus-becks tyrannosaurus-becks

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding new vault_identity_entity_alias causes runtime panic
3 participants
@kalafut @catsby @tyrannosaurus-becks