Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate MongoDB tests as part of the CircleCI build #662

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

tyrannosaurus-becks
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks commented Jan 31, 2020

This PR adds automation that will run our tests for MongoDB as part of our CircleCI run. It also standardizes the Mongo backend to be more like the other ones.

Also, this will be nice because now we'll have two databases running tests against changes to the shared database code. This means it'll be harder to introduce a change that works for one db, but breaks another.

Copy link
Contributor

@kalafut kalafut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tyrannosaurus-becks tyrannosaurus-becks merged commit 919e04d into master Feb 5, 2020
@tyrannosaurus-becks tyrannosaurus-becks deleted the add-mongo-circleci-tests branch February 5, 2020 17:51
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants