Add region passing for non commercial regions #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 24, 2020 16:22
This allows us to use non-inferrable regions
This allows the tf config to specify the region. It creates redundancy, however, it should allow people to use a different region without special permissions of any sort. If no region is given, it should default to us-east-1.
ghost
added
the
| return fmt.Sprintf(` | ||
| resource "vault_aws_secret_backend" "aws" { | ||
| path = "%s" | ||
| description = "Obtain AWS credentials." | ||
| access_key = "%s" | ||
| secret_key = "%s" | ||
| region = "%s" |
There was a problem hiding this comment.
Looks like a formatting error here.
There was a problem hiding this comment.
I could have sworn that I added something to goland to run gofmt on files on save...
kalafut
changed the title
This allows us to set the region ONLY if it was specified in the data section of the user's Terraform config.
jasonodonnell
approved these changes
Aug 10, 2020
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
* Add support for passing region information to vault backend This allows us to use non-inferrable regions * Remove unnecessary data passing when obtaining region * Remove root privilege check, add region as part of data source This allows the tf config to specify the region. It creates redundancy, however, it should allow people to use a different region without special permissions of any sort. If no region is given, it should default to us-east-1. * Rely on go zero values for modifying aws.Config This allows us to set the region ONLY if it was specified in the data section of the user's Terraform config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use non-inferrable regions with terraform and the vault provider.
Community Note
Relates OR Closes #679
Release note for CHANGELOG:
Add support for passing region information stored in vault backend to AWS Config
Output from acceptance testing:
(Note: You need numerous environment variables to be set for these acceptance tests to run.
The following env vars must be set based on information provided by your AWS instance. In order to truly test these changes, you'll need to get Access Keys from the us-gov-west-1 cloud, as those credentials were the ones that didn't work which prompted this change (You can also use cn-northwest-1 to test this if you'd like).