-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add version check for vsan hci mesh #1931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! BUt will ask @appilon for review.
Co-authored-by: Ryan Johnson <ryan@tenthirtyam.org>
Co-authored-by: Ryan Johnson <ryan@tenthirtyam.org>
Thanks @appilon @tenthirtyam for catching this, just committed changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot easily test this situation but it seems fine. In general I don't like that these version edgecases are littered throughout the provider and sort of "silently fail". I think I'd prefer warnings or errors if a user tries to configure an attribute they don't have support for, but we can continue with precedant.
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add version check before handling vSAN HCI Mesh, since this feature is supported in 70U1 or later.
Test Result:
Acceptance tests
Output from acceptance testing:
End-to-end test on vSphere 7.0 with only vSAN enabled. Configuration won't be failed anymore.
Release Note
Release note for CHANGELOG:
References
Closes #1925