fix: add memory_reservation_locked_to_max property to r/vsphere_virtual_macine schema for sr-iov
#2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsphere_virtual_macine schema Fixes hashicorp#2091 The memory_reservation_locked_to_max property was missing from vsphere_virtual_macine schema (both data and resource). The property of the VM was automaticaly set to false if memory and memory_reservation properties have different values. With this commit the property can be set to true explicitly and it will be applied only if memory and memory_reservation properties have same values. If the memory_reservation_locked_to_max is not explicitly set to true the original behavior is preserved. Signed-off-by: Vasil Atanasov <vasila@vmware.com>
tenthirtyam
changed the title
memory_reservation_locked_to_max property to r/vsphere_virtual_macine schema for sr-iov
tenthirtyam
changed the title
memory_reservation_locked_to_max property to r/vsphere_virtual_macine schema for sr-iovmemory_reservation_locked_to_max property to r/vsphere_virtual_macine schema for sr-iov
tenthirtyam
added
bug
iBrandyJackson
approved these changes
Jan 8, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
memory_reservation_locked_to_maxproperty was missing fromvsphere_virtual_macineschema (both data and resource). The property of the VM was automatically set tofalseifmemoryandmemory_reservationproperties have different values.With this commit the property can be set to true explicitly and it will be applied only if
memoryandmemory_reservation propertieshave same values. If thememory_reservation_locked_to_maxis not explicitly set totruethe original behaviour is preserved.Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Closes #2091